What does this PR do?

Restructures test_get_oauth_token_errors in cloud_foundry_api so its aggregator.assert_service_check(...) calls actually execute.

Motivation

Each error block wrapped both the raising call and the assertions after it in the same pytest.raises(...) context:

with mock.patch.object(check, "_http") as http_mock, pytest.raises(RequestException):
    http_mock.get.side_effect = RequestException()
    check.get_oauth_token()
    aggregator.assert_service_check(...)  # never runs
    aggregator.reset()                     # never runs

check.get_oauth_token() raises before reaching the lines after it, so pytest.raises catches the exception and exits the with block immediately, which means that the assertion and reset are dead code. The fix nests pytest.raises around only the raising call, so the assertions run after the exception is caught, once get_oauth_token has already emitted its CRITICAL service check.

This is a pre-existing test bug, called out separately from the W1b cloud_foundry_api catch-widening plan as explicitly out of scope there. It's unrelated to the httpx migration, so this PR targets master directly.

Verification

• Proved the assertions were dead code before fixing: swapped the expected status to OK (a value production never emits on this path) and confirmed the test still passed.
• Applied the fix, re-ran, and confirmed the test passes for the right reason.
• Re-ran the same OK-swap mutation against the fixed test and confirmed it now correctly fails, then reverted to the correct CRITICAL assertion.
• ddev --no-interactive test cloud_foundry_api: all 23 tests pass.
• ddev test -fs cloud_foundry_api: formatting and lint clean.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
• If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged